Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bootstrap policy file encoding #19756

Merged
merged 2 commits into from
May 22, 2018
Merged

Update bootstrap policy file encoding #19756

merged 2 commits into from
May 22, 2018

Conversation

mrogers950
Copy link
Contributor

@mrogers950 mrogers950 commented May 17, 2018 •
edited
Loading

Also remove the shared resource namespace flag
Fixes #15825
@openshift/sig-security

@openshift-ci-robot openshift-ci-robot added sig/security size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2018
@enj enj mentioned this pull request May 22, 2018
Merged
@enj
Copy link
Contributor

enj commented May 22, 2018

@mrogers950 see mrogers950#1

@enj enj removed the request for review from csrwng May 22, 2018 02:25
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 22, 2018
@mrogers950
Copy link
Contributor Author

@enj thanks! @simo5 please ack

@simo5
Copy link
Contributor

simo5 commented May 22, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2018
Matt Rogers and others added 2 commits May 22, 2018 10:22
Update bootstrap policy file encoding
516472a 
Also remove the shared namespace flag
@enj
Generated
50e5a1e 
Signed-off-by: Monis Khan <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2018
@enj
Copy link
Contributor

enj commented May 22, 2018

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2018
simo5
simo5 approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, mrogers950, simo5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c86f55d into openshift:master May 22, 2018
@enj enj mentioned this pull request May 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simo5 simo5 simo5 approved these changes

Assignees

@simo5 simo5

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/security size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrogers950 @enj @simo5 @openshift-ci-robot @openshift-merge-robot